[devops] Stop provisioning Mono. #21411

rolfbjarne · 2024-10-10T14:49:55Z

It's not needed during our build anymore.

mandel-macaque · 2024-10-10T18:14:23Z

You probably need to remove the use of the cache in the yml file that stored the mono download.

github-actions · 2024-10-10T18:14:55Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

stephen-hawley · 2024-10-10T18:17:08Z

system-dependencies.sh

@@ -651,6 +667,9 @@ function check_mono () {
 		if ! test -z $PROVISION_MONO; then
 			install_mono
 			ACTUAL_MONO_VERSION=`cat $MONO_VERSION_FILE`
+		elif test -n "$OPTIONAL_MONO"; then
+			warn "It's recommended to have no higher than Mono $MAX_MONO_VERSION, found $ACTUAL_MONO_VERSION. Download URL: $MIN_MONO_URL"


I just want to say for the record that I love how if a resource isn't available that you direct the user where to download the right version.

Also avoid the 'nuget' binary, which requires Mono.

…dependency

vs-mobiletools-engineering-service2 · 2024-10-15T08:16:13Z

🔥 [CI Build] Build failed 🔥

Build failed for the job 'Build macOS tests'

Pipeline on Agent
Hash: d14d4382d18388f9bc36fb1fd6dcfd0f2649a723 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T17:38:09Z

🔥 Failed to compare API and create generator diff 🔥

Error: The system requirements for the hash to compare against (209de6f) are different than for the current hash. Comparison is currently not supported in this scenario.

Pipeline on Agent
Hash: e3054339080f271f581772279cee19f7ca1b8e71 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T18:02:07Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: e3054339080f271f581772279cee19f7ca1b8e71 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T18:09:09Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: e3054339080f271f581772279cee19f7ca1b8e71 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T18:13:43Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: e3054339080f271f581772279cee19f7ca1b8e71 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T18:14:10Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: e3054339080f271f581772279cee19f7ca1b8e71 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T20:50:06Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

5 tests crashed, 3 tests failed, 66 tests passed.

Failures

❌ dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (macOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

🔥 Failed catastrophically on VSTS: test results - monotouch_ios (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

🔥 Failed catastrophically on VSTS: test results - monotouch_maccatalyst (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

🔥 Failed catastrophically on VSTS: test results - monotouch_macos (no summary found).

Html Report (VSDrops) Download

❌ msbuild tests

🔥 Failed catastrophically on VSTS: test results - msbuild (no summary found).

Html Report (VSDrops) Download

❌ xcframework tests

🔥 Failed catastrophically on VSTS: test results - xcframework (no summary found).

Html Report (VSDrops) Download

❌ xtro tests

1 tests failed, 0 tests passed.

Xtro/.NET: BuildFailure

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: e3054339080f271f581772279cee19f7ca1b8e71 [PR build]

[devops] Stop provisioning Mono.

4ed5c03

It's not needed during our build anymore.

This comment has been minimized.

Sign in to view

[system-dependencies] Make Mono optional.

8144277

This comment has been minimized.

Sign in to view

rolfbjarne added 8 commits October 10, 2024 19:56

[csharp] Port the versions-check.csharp script to a .NET project.

794efff

[csharp] Port csharp scripts in src/ to .NET projects.

a7a046e

[csharp] Port csharp scripts in dotnet/ to .NET projects.

c139a22

[csharp] Port csharp scripts in tests/ to .NET projects.

db7dd76

sqgenerateerrors

71db0cb

sqsrc

d4ad674

sqtests

5b52d6f

Merge remote-tracking branch 'origin/main' into remove-mono-dependency

421853a

Auto-format source code

210ce59

stephen-hawley reviewed Oct 10, 2024

View reviewed changes

stephen-hawley approved these changes Oct 10, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

Step by step.

584e61b

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits October 11, 2024 12:08

Step by step, v2

c2f674a

Step by step, v3 - use ilrepack to sign instead of sn.

efc06ba

rolfbjarne added 2 commits October 14, 2024 10:51

[tests] Simplify code to build test NuGets.

1280774

Also avoid the 'nuget' binary, which requires Mono.

Merge remote-tracking branch 'origin/main' into dev/rolf/remove-mono-…

d14d438

…dependency

This comment has been minimized.

Sign in to view

Tools

0b6b8e0

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits October 15, 2024 15:10

Package a bit more.

beb8127

Remove more stuff.

0e843bb

This comment has been minimized.

Sign in to view

rolfbjarne added 4 commits October 15, 2024 17:36

Don't build in parallel, it pretty much fails all the time.

36b12c4

Package more.

a33f0d7

[devops] Install .NET on macOS bots.

e0f5fe9

Use system .NET.

e305433

This comment has been minimized.

Sign in to view

[devops] Stop provisioning Mono. #21411

Are you sure you want to change the base?

[devops] Stop provisioning Mono. #21411

Conversation

rolfbjarne commented Oct 10, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

⚠️ Your code has been reformatted. ⚠️

stephen-hawley Oct 10, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 15, 2024

🔥 [CI Build] Build failed 🔥

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 15, 2024

vs-mobiletools-engineering-service2 commented Oct 15, 2024

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Oct 15, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Oct 15, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Oct 15, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Oct 15, 2024

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ dotnettests tests (MacCatalyst)

❌ dotnettests tests (macOS)

❌ monotouch tests (iOS)

❌ monotouch tests (MacCatalyst)

❌ monotouch tests (macOS)

❌ msbuild tests

❌ xcframework tests

❌ xtro tests

Successes