Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tb 4009 placeholder ads #564

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

frankpepermans
Copy link
Contributor

What 🕵️ 🔍

  • What does the pull request solve?
  • What exactly was added or modified?

How to test (please adjust template) 🥼 🔬

  • Feature flag enabled:
    Test main feature, and verify that all aspects of the story are working as described in the PR and the Jira story

    • step №1
    • step №2
  • Feature flag disabled:

    • Check affected area that still behave as expected without the feature
  • Feature affects new Engine/ Card manager / Settings / DB changes / Architecture update

    • Go to Setting, change language :
      • Verify that the Feed shows articles in the new language
      • Verify that like/ dislike / bookmark, visually works
      • Verify that articles show up in bookmarks
      • Verify search works and articles show up in the new language
  • Feature has DB change

    • Upgrade test from previous version, verify that the app starts and that the affected area works as expected
  • Feature affects platform dependent code

    • Verify feature on iOS
    • Verify feature on Android
  • Feature affects UI changes

    • Verify on iPhone SE / [Small Android]
    • (default) Verify on Pro 13 Max / (Big Android)

Screenshots 📸 📱

Before After

References 📝 🔗


@frankpepermans frankpepermans self-assigned this Jul 6, 2022
@frankpepermans frankpepermans added the WIP ⏳ Should be used when PR is not ready for review, work in progress label Jul 6, 2022
@joecks joecks added the PoC label Jul 12, 2022
@joecks joecks force-pushed the TB-4009_placeholder_ads branch 3 times, most recently from ee7c5d8 to 88ef155 Compare July 19, 2022 08:11
joecks
joecks previously approved these changes Jul 19, 2022
@joecks joecks marked this pull request as ready for review July 19, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PoC WIP ⏳ Should be used when PR is not ready for review, work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants