add a helper for running futures concurrently #541
Conversation
little-dude
force-pushed
the
concurrent_futures
branch
2 times, most recently
from
5ee9efe
to
46ecb8f
Compare
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 60.67% 60.76% +0.09%
==========================================
Files 96 97 +1
Lines 4399 4412 +13
==========================================
+ Hits 2669 2681 +12
- Misses 1730 1731 +1
Continue to review full report at Codecov.
|
janpetschexain
force-pushed
the
concurrent_futures
branch
from
46ecb8f
to
684ec54
Compare
|
rebased. we should probably move this to the |
This will allow clients to start sending multiple chunks concurrently. [`FuturesUnordered`](https://docs.rs/futures-util/0.3.5/futures_util/stream/futures_unordered/struct.FuturesUnordered.html) allows us to poll multiple futures, but if we want to really run them _concurrently_ we need to spawn them first. So this type is just a thin wrapper around `FuturesUnordered`.
janpetschexain
force-pushed
the
concurrent_futures
branch
from
684ec54
to
16ed2e9
Compare
|
What are you guys going to use this for? I forgot why I did that in the first place |
@Robert-Steiner wants to use it for the e2e tests, but they are not mergeable yet. since we are cleaning up things for the next release, we want to merge this so it doesn't get lost. |
|
Forgot to mention why I didn't want to use
(Commenting because I'm having a similar use case again and I was wondering whether I should use |
This will allow clients to start sending multiple chunks concurrently.
FuturesUnorderedallows us to poll multiple futures, but if we want to really run them
concurrently we need to spawn them first. So this type is just a thin
wrapper around
FuturesUnordered.