rinv dimm display for Power nodes #6858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurevichmark
force-pushed
the
rinv_dimm
branch
from
5d4a7e7
to
caea18c
Compare
|
@gurevichmark I did some research on this issue, and the fact that the data displays incorrectly in ipmitool seems like a clue to me. I found this issue that may be related: open-power/hostboot#132 That issue then has references to a few other related pull requests. However, I think it is possible that the issue we are seeing with Before we merge this change, I would like to better understand a few things about this. |
besawn
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to fix issue #6377
On Power nodes, dimm information is not returned with
fru_subtype=2, as it is on x86 nodes.This PR uses
id_string=~"DIMM"instead to decide which data is DIMM related.Additionally
spd_decode()should not be used to parse DIMM data from Power nodes, insteadparsefru()should be used.UT on available nodes:
rinv dimmrinv hwipmitoolipmitoolipmitoolipmitoolrinv dimmrinv hwipmitoolipmitoolipmitoolipmitoolipmitoolipmitoolipmitoolipmitool8247-42L:c910f04x14:briggs01with older FW levels (ipmitoolreturns the same):