Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qmulconfignetwork #7092

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChristopherWalker
Copy link

The PR is to fix issue #6142

The modification includes

## Add -r option to confignetwork to remove unconfigured network devices (note If device has parameters defined in xCAT, leave it alone)

##item2

The UT result

##The UT output##

Please remove this line and below if fix issue

Please remove this line and above for tasks or features

The PR is for task #xxx or to implement feature #xxx

##Feature description##

The content of the PR:

  • ##The mini-design link
  • ##The basic code logic

The UT result

##The UT output##

Christopher J. Walker and others added 2 commits January 7, 2022 16:05
* confignics used to have the option of removing unconfigured network devices
  Add this to confignetwork - fixes xcat2#6142
* If device has parameters defined in xCAT, leave it alone
@ChristopherWalker
Copy link
Author

It's not clear that this is completely ready to be pulled - I'd welcome some code review.

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ChristopherWalker
❌ Christopher J. Walker


Christopher J. Walker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants