Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XDG_STATE_HOME #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add XDG_STATE_HOME #43

wants to merge 1 commit into from

Conversation

piegamesde
Copy link

Not released yet, but it's already part of the spec: $XDG_STATE_HOME.

I added support for it in this crate by copy-pasting and following existing patterns as much as possible. As it's not officially released yet, maybe it should be hidden behind a feature flag?

I don't know anything about Windows and Mac, so I simply answered that question with None. I think implementing it for these platforms can be done in a future work. (I wouldn't want to do it since I can't test it.)

@tesuji
Copy link
Contributor

tesuji commented Jan 5, 2021

Thanks for the PR. I'm sorry for the late in reviewing. I've been away from computer for a time.

I searched in https://gitlab.freedesktop.org/xdg/xdg-specs/-/blob/master/basedir/basedir-spec.xml
but I didn't find any mentions of XDG_STATE_HOME.

I'm sorry, firefox search feature lied to me. I can find the XDG_STATE_HOME in that file after doing the search
one more time.

You told that the new spec is not released. So do you think in the meantime
wait for the new spec is OK?

@piegamesde
Copy link
Author

You told that the new spec is not released. So do you think in the meantime
wait for the new spec is OK?

I think that's up to you to decide. See also the discussion in whitequark/rust-xdg#33 about this topic.

I think I'll go and ask for a proper release, but don't expect anything to happen soon.

@tesuji tesuji added the S-blocked Status: blocked on something happening somewhere else label Jan 10, 2021
@piegamesde
Copy link
Author

The spec won't move in any direction anytime soon, so don't expect any releases there. Are you still interested in this?

@rydalt
Copy link

rydalt commented May 15, 2022

The spec won't move in any direction anytime soon, so don't expect any releases there.

Maybe I'm missing something, but every variant of the spec I can find suggests this was released a little over a year ago now. Notably both the Freedesktop.org Specifications page for basedir version 0.8 and the xdg gitlab variant list $XDG_STATE_HOME.

@piegamesde
Copy link
Author

True. How could I miss that? Thanks for the notice

@rydalt
Copy link

rydalt commented May 15, 2022

Actually I was digging around a bit more, it looks like this was added and released in dirs 4.0.0. This is the repo where development is happening for dirs now which threw me off since I got to here from another issue blocked by this and didn't look at the readme

@ammgws
Copy link

ammgws commented May 16, 2022

True. How could I miss that? Thanks for the notice

Their site wasn't updated until well after the fact so the only way to know at the time was if you were following the upstream repo itself.

@Decodetalkers
Copy link

Decodetalkers commented Jul 6, 2023

ping... do this has any process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: blocked on something happening somewhere else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants