Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject comma in time format #339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reject comma in time format #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions format_checkers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,15 @@ func (f TimeFormatChecker) IsFormat(input interface{}) bool {
return true
}

_, err := time.Parse("15:04:05", asString)
return err == nil
parsed, err := time.Parse("15:04:05", asString)
if err != nil {
return false
}

// Go1.17 accepts comma "," as a separator for fractional seconds,
// But RFC3339 doesn't.

return parsed.Format("15:04:05") == asString
}

// IsFormat checks if input is correctly formatted URI with a valid Scheme per RFC3986
Expand Down