This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Add log file when stdout is invalid #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks on startup whether or not stdout is invalid. If it is invalid then it creates a log file which stdout and stderr are piped into.
|
Thanks and sorry for not reviewing earlier. There's been some motion in this space, #62 adds a console if available, and #60 is a proposal to use proper logging infrastructure. This PR is not mergeable now, so wondering whether we should close it. I know that's not a great "new developer" experience, apologies again. |
|
I think we should close this too. Thanks for the response! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks on startup whether or not stdout is invalid. If it is
invalid then it creates a log file which stdout and stderr are piped
into.
Also, this currently places a file called log.txt into the root of the crate. I believe xi-core places logs in the AppData/Local/xi-core folder on windows so maybe the logs should be placed there?
P.S. I am by no means an expert on winapi/unsafe code so there might be some things that need changed!