Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit Qt UI design from .ui files #6

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
eb81998
Replace hard-coded main window with .ui design
benjaminhwilliams Nov 17, 2020
28c9e5a
Add .ui design for the xia2 options window
benjaminhwilliams Nov 20, 2020
8a5cde8
Show all Python LGTM query results
benjaminhwilliams Nov 20, 2020
9faf130
Fix xia2 options window parentage
benjaminhwilliams Nov 21, 2020
d5f02d3
Add a margin to the xia2 options window
benjaminhwilliams Nov 21, 2020
5b79f4b
Make removal of exit button more robust
benjaminhwilliams Nov 24, 2020
02c9027
Make some margins more consistent
benjaminhwilliams Nov 24, 2020
e3d57ce
Update some attribute names to match Qt camelCase
benjaminhwilliams Nov 25, 2020
0ada396
Add some more tool tips to the .ui design file
benjaminhwilliams Nov 25, 2020
d855070
Slightly improve appearance of textEdit and labels
benjaminhwilliams Nov 26, 2020
bc61ff5
Improve selection of reference instrument model
benjaminhwilliams Nov 26, 2020
e406682
Link duplicate widgets with signals → slots
benjaminhwilliams Nov 27, 2020
861fd33
Remove redundant import
benjaminhwilliams Nov 27, 2020
fbe90d7
Remove unused parameter
benjaminhwilliams Nov 28, 2020
638d17c
Simplify the tab closing behaviour
benjaminhwilliams Nov 28, 2020
9b4c493
Correct some typos and rationalise capitalisation
benjaminhwilliams Nov 30, 2020
f25dca9
Simplify logic for saving and loading xia2 options
benjaminhwilliams Dec 2, 2020
75b664f
Simplify Qt string translation
benjaminhwilliams Dec 2, 2020
1fb2212
Add precommit hooks to check and format JSON files
benjaminhwilliams Dec 2, 2020
5a2f8ff
Simplify the logging call from a UIOptionsWindow
benjaminhwilliams Dec 3, 2020
c9f440c
Use some sensible default parameters
benjaminhwilliams Dec 3, 2020
d38e701
Log the absence of previous auto-saved options
benjaminhwilliams Dec 4, 2020
0be95bc
Define the translation of options to PHIL params
benjaminhwilliams Dec 4, 2020
491a721
Remove redundant checkboxes, clarify labels
benjaminhwilliams Dec 15, 2020
8c2543d
Connect some more duplicate widgets
benjaminhwilliams Dec 15, 2020
b4d1d7b
Find numbers in multi-number input by regex
benjaminhwilliams Dec 16, 2020
25f32d6
Repeat ourselves programatically
benjaminhwilliams Dec 16, 2020
2eea7a8
Correct some option specifications
benjaminhwilliams Dec 16, 2020
7c5cdc6
Tidy up main widow module attributes
benjaminhwilliams Dec 16, 2020
3670442
Simplify update_options using new parameter spec
benjaminhwilliams Dec 16, 2020
f68831c
Simplify mapping of phil parameter generation
benjaminhwilliams Dec 16, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .lgtm.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
queries:
- include: "py/*"
- include: "*"
3 changes: 3 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ repos:
- id: end-of-file-fixer
- id: requirements-txt-fixer
- id: check-ast
- id: check-json
- id: pretty-format-json
args: [--autofix, --no-ensure-ascii, --no-sort-keys]
- id: check-yaml
- id: check-merge-conflict
- id: check-added-large-files
Expand Down
Loading