Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure libtheoraenc do not need libtheoradec #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petterreinholdtsen
Copy link

Addresses issue reported in https://bugs.debian.org/923940 about some symbols being unresolved.

Addresses issue reported in https://bugs.debian.org/923940 about some symbols being unresolved.
@rillian
Copy link
Contributor

rillian commented Apr 15, 2020

The debian bug is already fixed on the master branch with this line in lib/Makefile.am

libtheoraenc_la_LIBADD = libtheoradec.la

which declares the transitive dependency in the ELF headers:

$ ldd _inst/usr/local/lib/libtheoraenc.so
	linux-vdso.so.1 (0x0000ffff9abfd000)
	libogg.so.0 => /lib/aarch64-linux-gnu/libogg.so.0 (0x0000ffff9ab5f000)
	libtheoradec.so.1 => /lib/aarch64-linux-gnu/libtheoradec.so.1 (0x0000ffff9ab36000)
        [...]

Nevertheless we might want to still do this, since info.c is the only remaining theoradec code not already duplicated. If so we'd need to also remove the line above update pkgconfig to drop the requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants