-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor]: Unary client #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LingKa <[email protected]>
LingKa28
force-pushed
the
feature/unary-client
branch
from
February 6, 2024 18:28
9c10ac5
to
12667a2
Compare
LingKa28
force-pushed
the
feature/unary-client
branch
2 times, most recently
from
February 6, 2024 19:07
a7674e0
to
ab2d690
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 83.57% 83.66% +0.08%
==========================================
Files 18 18
Lines 1120 1120
Branches 84 84
==========================================
+ Hits 936 937 +1
+ Misses 157 156 -1
Partials 27 27 ☔ View full report in Codecov by Sentry. |
LingKa28
added
the
Improvement
Refactor or optimization, including process, performance or something like that
label
Feb 6, 2024
Closed
4 tasks
iGxnon
reviewed
Feb 7, 2024
Signed-off-by: LingKa <[email protected]>
Signed-off-by: LingKa <[email protected]>
LingKa28
force-pushed
the
feature/unary-client
branch
from
February 7, 2024 17:05
ab2d690
to
b16767b
Compare
iGxnon
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Phoenix500526
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Add unary client.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No.