Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: Unary client #16

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Conversation

LingKa28
Copy link
Contributor

@LingKa28 LingKa28 commented Feb 1, 2024

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Add unary client.

  • what changes does this pull request make?

    • add unary builder.
    • add unary clinet.
    • add unary test.
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    No.

@LingKa28 LingKa28 marked this pull request as ready for review February 6, 2024 18:35
@LingKa28 LingKa28 force-pushed the feature/unary-client branch 2 times, most recently from a7674e0 to ab2d690 Compare February 6, 2024 19:07
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2dedc07) 83.57% compared to head (b16767b) 83.66%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   83.57%   83.66%   +0.08%     
==========================================
  Files          18       18              
  Lines        1120     1120              
  Branches       84       84              
==========================================
+ Hits          936      937       +1     
+ Misses        157      156       -1     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LingKa28 LingKa28 added the Improvement Refactor or optimization, including process, performance or something like that label Feb 6, 2024
@LingKa28 LingKa28 added this to the v0.1.2 milestone Feb 6, 2024
@LingKa28 LingKa28 linked an issue Feb 6, 2024 that may be closed by this pull request
4 tasks
src/curp/__init__.py Outdated Show resolved Hide resolved
src/rpc/__init__.py Outdated Show resolved Hide resolved
src/rpc/connect.py Show resolved Hide resolved
src/rpc/connect.py Show resolved Hide resolved
@LingKa28 LingKa28 self-assigned this Feb 7, 2024
Copy link

@iGxnon iGxnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LingKa28 LingKa28 changed the title [Feature]: Unary client [Refactor]: Unary client Feb 8, 2024
@mergify mergify bot mentioned this pull request Feb 8, 2024
src/curp/unary.py Show resolved Hide resolved
src/curp/unary.py Show resolved Hide resolved
@Phoenix500526 Phoenix500526 merged commit e511f84 into xline-kv:main Feb 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Refactor or optimization, including process, performance or something like that
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor]: Curp client
3 participants