Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: watch clinet #8

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

LingKa28
Copy link
Contributor

@LingKa28 LingKa28 commented Dec 6, 2023

Base on #2

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Add new feature

  • what changes does this pull request make?

    • add watch client
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    No.

Copy link

mergify bot commented Dec 6, 2023

⚠️ The sha of the head commit of this PR conflicts with #7. Mergify cannot evaluate rules on this PR. ⚠️

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf2e30a) 91.28% compared to head (aa36e3f) 92.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   91.28%   92.32%   +1.04%     
==========================================
  Files          10       12       +2     
  Lines         608      691      +83     
  Branches       32       41       +9     
==========================================
+ Hits          555      638      +83     
  Misses         39       39              
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
tests/auth_test.py Outdated Show resolved Hide resolved
tests/auth_test.py Outdated Show resolved Hide resolved
tests/auth_test.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LingKa28 LingKa28 merged commit 4d2dede into xline-kv:main Dec 8, 2023
8 checks passed
@LingKa28 LingKa28 mentioned this pull request Dec 9, 2023
@LingKa28 LingKa28 deleted the feature/watch-clinet branch December 9, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants