Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom registration fields #432

Closed
wants to merge 1 commit into from
Closed

Add support for custom registration fields #432

wants to merge 1 commit into from

Conversation

AlMcKinlay
Copy link

Fixes #431

This allows the client to specify fields that will be sent with the registration, and then passes all of them to the server register emit.

I couldn't see any existing appropriate tests for these, and didn't have time to make any from scratch today.

@sonnyp
Copy link
Member

sonnyp commented Jun 19, 2017

Unfortunately I don't accept non security related PR for node-xmpp-client as its architecture doesn't allow for growth.

There's a rewrite in progress that addresses this issue though and we even have a registration plugin but it needs to be updated. I'll do that ASAP and I'll keep your use case in mind. I'll let you know on #431

@sonnyp sonnyp closed this Jun 19, 2017
@AlMcKinlay
Copy link
Author

AlMcKinlay commented Jun 19, 2017 via email

@sonnyp
Copy link
Member

sonnyp commented Jun 19, 2017

@YaManicKill that's correct meanwhile I recommend you keep using your fork. The rewrite provides a different API so you might wanna keep that in mind.

@AlMcKinlay
Copy link
Author

Alright, well thanks anyway, @sonnyp

@sonnyp
Copy link
Member

sonnyp commented Oct 4, 2019

see #783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants