Some improvements to parsing when using normalize_names=True. #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfhowes
commented
Jan 11, 2024
| @@ -238,7 +238,7 @@ def p_id(self, p): | |||
| delimiters_to_end = ["`", '"', "]"] | |||
| p[0] = p[1] | |||
|
|
|||
| if self.normalize_names: | |||
| if self.normalize_names and len(p[0]) > 2: | |||
There was a problem hiding this comment.
this was causing [] to be removed, which are needed in statements like decimal(21)[]
cfhowes
commented
Jan 11, 2024
| @@ -221,7 +221,7 @@ def process_type(self, _type: Union[str, List], p_list: List, p: List) -> str: | |||
| p[0] = {"property": {"distkey": True}} | |||
| _type = _type.split("distkey")[0] | |||
|
|
|||
| _type = _type.strip().replace('" . "', '"."') | |||
| _type = _type.strip().replace(" . ", ".") | |||
There was a problem hiding this comment.
I can't think of a reason to want to keep the space around the dots if the strings are unquoted, so i simplified to this. This then allows the PR i'm about to make to omymodels pass existing tests....
There was a problem hiding this comment.
again, looks like it was 'historical context'
xnuinside
approved these changes
Jan 11, 2024
|
@cfhowes thanks for PR! merged |
|
@cfhowes released version 1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some issues when using normalize_names=True that I wanted to fix:
decimal(21)[]would have the final[]removed since it was parsed as its own id by the parser."complex"."type"tocomplex . typewould was surprising to other tools (omymodels...)