Skip to content

Commit

Permalink
Minor cleanup in unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
kenshaw committed Jan 16, 2024
1 parent cda926d commit 08d366a
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions vegagoja_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,14 @@ import (
)

func TestVersion(t *testing.T) {
clean := func(s string) string {
return strings.TrimPrefix(strings.TrimSpace(s), "v")
}
vegaVer, liteVer, err := New().Version()
if err != nil {
t.Fatalf("expected no error, got: %v", err)
}
if v, exp := clean(vegaVer), clean(string(vegaVersionTxt)); v != exp {
if v, exp := cleanString(vegaVer), cleanString(string(vegaVersionTxt)); v != exp {
t.Errorf("expected %s, got: %s", exp, v)
}
if v, exp := clean(liteVer), clean(string(liteVersionTxt)); v != exp {
if v, exp := cleanString(liteVer), cleanString(string(liteVersionTxt)); v != exp {
t.Errorf("expected %s, got: %s", exp, v)
}
t.Logf("vega: %s vega-lite: %s", vegaVer, liteVer)
Expand Down Expand Up @@ -97,6 +94,10 @@ func testRender(t *testing.T, ctx context.Context, testName, name string, timeou
}
}

func cleanString(s string) string {
return strings.TrimPrefix(strings.TrimSpace(s), "v")
}

func contains(v []string, s string) bool {
for _, ss := range v {
if ss == s {
Expand Down

0 comments on commit 08d366a

Please sign in to comment.