Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix latched pulse always being HIGH #2145

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Fix latched pulse always being HIGH #2145

merged 1 commit into from
Feb 18, 2020

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Feb 13, 2020

@mcspr
Copy link
Collaborator Author

mcspr commented Feb 13, 2020

CI issue seems to be Platformio 4.2.0 release issue, need to check that.

Regarding INVERSE type:

~/D/P/P/e/m/code>  git grep RELAY_TYPE_LATCHED -- espurna/config/hardware.h
espurna/config/hardware.h:// RELAY#_TYPE: Relay can be RELAY_TYPE_NORMAL, RELAY_TYPE_INVERSE, RELAY_TYPE_LATCHED or RELAY_TYPE_LATCHED_INVERSE
espurna/config/hardware.h:    #define RELAY1_TYPE         RELAY_TYPE_LATCHED
espurna/config/hardware.h:    #define RELAY1_TYPE         RELAY_TYPE_LATCHED
espurna/config/hardware.h:    #define RELAY2_TYPE         RELAY_TYPE_LATCHED
espurna/config/hardware.h:    #define RELAY1_TYPE             RELAY_TYPE_LATCHED

There is no LATCHED_INVERSE pre-configured hardware, issue will only happen when someone uses custom build.

One recent issue mentions it:
#1855 (comment)

@mcspr mcspr merged commit 0d5129d into dev Feb 18, 2020
@mcspr mcspr deleted the mcspr-patch-1 branch February 18, 2020 09:14
@mcspr mcspr added this to the 1.14.2 milestone Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mcspr