support for esp8266 serial, UART_TO_MQTT #2183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcspr
reviewed
Mar 17, 2020
| #define UART_MQTT_USE_SOFT 0 | ||
| #define UART_MQTT_HW_PORT Serial | ||
| #define UART_MQTT_BAUDRATE 115200 | ||
| #define TERMINAL_SUPPORT 0 |
There was a problem hiding this comment.
Looking at terminal.ino, it never calls Serial.read() unless debug_serial_support flag is on (which is off here).
There was a problem hiding this comment.
(this comment was meant to point to the disabled TERMINAL_SUPPORT)
|
You are using out-of-date branch btw, there is no need in migrate.ino and platformio.ini was changed considerably |
|
True, might do a new PR instead. But it works really fine with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.