Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement support for st7735 display #2319

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Conversation

dpeddi
Copy link
Contributor

@dpeddi dpeddi commented Aug 12, 2020

initial support for st7735 display

@dpeddi
Copy link
Contributor Author

dpeddi commented Aug 12, 2020

image
image
image
image

code/espurna/thermostat.h Outdated Show resolved Hide resolved
code/espurna/thermostat.h Outdated Show resolved Hide resolved
code/platformio.ini Show resolved Hide resolved
code/espurna/main.cpp Outdated Show resolved Hide resolved
code/espurna/thermostat.cpp Outdated Show resolved Hide resolved
code/espurna/thermostat.cpp Show resolved Hide resolved
code/espurna/Roboto_Thin9pt8b.h Outdated Show resolved Hide resolved
code/espurna/thermostat.cpp Outdated Show resolved Hide resolved
code/espurna/thermostat.cpp Outdated Show resolved Hide resolved
code/espurna/thermostat.cpp Outdated Show resolved Hide resolved
@dpeddi
Copy link
Contributor Author

dpeddi commented Aug 18, 2020

the original developer used ThingPulse/esp8266-oled-ssd1306, if someone who have ssd1306 would move to adafruit/Adafruit_SSD1306 probably there would be less ifdef.

Next step may be to create a display "class" to be referenced from espurna itself for ip address/ssid and/or relay status..

@mcspr
Copy link
Collaborator

mcspr commented Aug 19, 2020

the original developer used ThingPulse/esp8266-oled-ssd1306, if someone who have ssd1306 would move to adafruit/Adafruit_SSD1306 probably there would be less ifdef.

idk about that. perhaps, availability and / or esp8266 quirks were handled better originally, but still it feels like Adafruit option is mostly targeted at other Arduino boards.
also check out https://github.com/lexus2k/ssd1306, despite the name it handles both of these displays.

Next step may be to create a display "class" to be referenced from espurna itself for ip address/ssid and/or relay status..

maybe. depends on what exactly relays will do. e.g. do we create sort-of 'window' / region and allow external thing to fully control it, or keep some specific spaces for 'info' and only allow data input

let me think about the example / pio.ini code a bit, I'll merge the PR after that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants