-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/madx misalignments #306
base: main
Are you sure you want to change the base?
Conversation
Please make sure not to break the ealign logic. |
Doesn't work if thin multipole has angle... |
Multipoles with angle are a bit special and we were considering changing the behaviour (as it is not documented yet). Have a look here for more details: |
Until (and if) behaviour is changed, should we replicate the track of mad-x? A particle entering a multipole (knl,ksl = 0, angle=a), and with an ealign diplacement dx, exits with a shift in the x coordinate equal to "dx * (a * sin(a) + cos(a) - 1 + O(1.e-5))". Since there can't be a change in the actual position of the particle, this change must be happening in the reference orbit. |
The matter is a bit tricky. Thin elements do not exist, (si)xtrack elements are indeed integration steps. I am not sure it makes sense to rotate an integration step in the general case, but it can work in specific cases. |
@rdemaria and @paraschou |
Closed by mistake |
Description
Order of dx/dy and dpsi when importing from madx error tables was wrong.
Added test to check, and reversed the order.
Fixes xsuite Issue # 302 (xsuite/xsuite#302)
tests/test_prebuild_kernels.py does not pass, but was also not passing before.
Checklist
Mandatory:
Optional: