Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWIKI-21115: @breadcrumb-color doesn't apply to links in the Breadcrumb #3536

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
+8 −2
Draft

XWIKI-21115: @breadcrumb-color doesn't apply to links in the Breadcrumb #3536

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39e119f
XWIKI-21116: @dropdown-link-color doesn't apply to breadcrumb's dropd…
Sereza7 Oct 3, 2024
603ab92
XWIKI-21115: @breadcrumb-color doesn't apply to links in the Breadcrumb
Sereza7 Oct 3, 2024
b17e0d8
Merge remote-tracking branch 'origin/XWIKI-21115' into XWIKI-21115
Sereza7 Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .../xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/less/breadcrumbs.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,15 @@

// Styles for the tree navigation.
&.dropdown {
> .dropdown-toggle {
/* We make sure the dropdown toggle carets and the links get the same colors. */
& > .dropdown-toggle, & > a {
color: @breadcrumb-color;
&:hover, &:focus {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the :active and :visited states?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no specific style for the active and visited states. Checked directly on my local distribution.
Note that if there was, we'd probably need to override any style added by the visited state, because it doesn't make sense for the buttons next to the links.

image

color: @breadcrumb-active-color;
}
}

> .dropdown-toggle {
cursor: pointer;
/* Match the separator padding */
margin: 2px;
Expand All @@ -32,7 +39,6 @@
line-height: .5rem;

&:hover, &:focus {
color: @breadcrumb-active-color;
/* We want to revert the default from bootstrap where the outline is removed... */
outline: revert;
}
Expand Down