XRENDERING-563: Handle metadata rendering in HTML macro #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmortagne
reviewed
May 13, 2019
...ml/src/main/java/org/xwiki/rendering/internal/macro/html/HTMLMacroXHTMLChainingRenderer.java
Outdated
Show resolved
Hide resolved
* Choose the right renderer based on the target syntax.
|
Everything's passing, however we decrease the mutation score with it, since the custom test suite are not handled:
I suggest to decrease it in the pom.xml since the new feature is actually tested, and we already have an open issue for it: STAMP-project/pitest-descartes#83 |
* Add the missing renderers..
tmortagne
reviewed
May 15, 2019
...tml/src/main/java/org/xwiki/rendering/internal/macro/html/HTMLMacroXHTMLRendererFactory.java
Outdated
Show resolved
Hide resolved
* Avoid NPE in ListenerChain by checking if a ChainingListener with an inherited class has been pushed * Add new syntax renderers in HTMLMacro and change the archi to use a wrappedListener for adding custom behaviours * Update tests on HTMLMacro
* Define an AbstractHTMLMacroRenderer for all renderers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://jira.xwiki.org/browse/XRENDERING-563
Solution
Handle the metadata in the custom HtmlMacroXHTMLRenderer the same way we do in AnnotatedXHTMLRenderer.