Skip to content

Commit

Permalink
[#122] Updated GitHub Actions (#123)
Browse files Browse the repository at this point in the history
* Introduced testing with Swift 5.9 and Swift 5.10
* Switched to Xcode 15.3 on macOS 14 runners
* Updated `TransparentFeatureFlagStore` to fix a compiler warning
* Removed an invalid URL from the podspec file
  • Loading branch information
yakovmanshin authored Apr 26, 2024
1 parent 7cd12b7 commit a246b13
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 12 deletions.
18 changes: 12 additions & 6 deletions .github/workflows/Common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,21 @@ on:
type: boolean
required: true
env:
XCODE_PATH: "/Applications/Xcode_14.3.1.app"
XCODE_PATH: "/Applications/Xcode_15.3.app"
jobs:
spm_tests_macos:
name: SPM Tests (Swift ${{ matrix.SWIFT_VERSION }} on macOS)
runs-on: ${{ matrix.OS }}
strategy:
matrix:
SWIFT_VERSION: ["5.8", "5.7", "5.5"]
SWIFT_VERSION: ["5.10", "5.9", "5.8", "5.7", "5.5"]
include:
- SWIFT_VERSION: "5.10"
OS: macos-14
XCODE_APP_NAME: "Xcode_15.3"
- SWIFT_VERSION: "5.9"
OS: macos-13
XCODE_APP_NAME: "Xcode_15.2"
- SWIFT_VERSION: "5.8"
OS: macos-13
XCODE_APP_NAME: "Xcode_14.3.1"
Expand All @@ -35,7 +41,7 @@ jobs:
OS: macOS-12
XCODE_APP_NAME: "Xcode_13.2.1"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Select Xcode Version
run: sudo xcode-select -switch "/Applications/${{ matrix.XCODE_APP_NAME }}.app"
- name: Run Tests
Expand All @@ -46,18 +52,18 @@ jobs:
name: SPM Tests (Linux)
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Run Tests
run: |
swift --version
swift test -v
cocoapods_podspec_lint:
name: CocoaPods Podspec Linting
runs-on: macos-13
runs-on: macos-14
if: ${{ inputs.force_all_checks || github.event_name == 'pull_request' }}
needs: [spm_tests_macos, spm_tests_linux]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Select Xcode Version
run: sudo xcode-select -switch ${{ env.XCODE_PATH }}
- name: Lint Podspec
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/Release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,20 @@ on:
release:
types: [published]
env:
XCODE_PATH: "/Applications/Xcode_14.3.1.app"
XCODE_PATH: "/Applications/Xcode_15.3.app"
jobs:
run_common_checks:
uses: ./.github/workflows/Common.yml
with:
force_all_checks: true
cocoapods_trunk_push:
name: Push to CocoaPods Trunk
runs-on: macos-13
runs-on: macos-14
needs: run_common_checks
env:
COCOAPODS_TRUNK_TOKEN: ${{ secrets.COCOAPODS_TOKEN }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Select Xcode Version
run: sudo xcode-select -switch ${{ env.XCODE_PATH }}
- name: Push
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ extension TransparentFeatureFlagStore: FeatureFlagStoreProtocol {
self[key] != nil
}

public func value<Value>(forKey key: String) -> Value? {
self[key] as? Value
public func value<V>(forKey key: String) -> V? {
self[key] as? V
}

}
1 change: 0 additions & 1 deletion YMFF.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ Pod::Spec.new do |s|
YMFF is a nice little library that makes management of features
with feature flags—and management of the feature flags themselves—a bliss.
DESC
s.documentation_url = "https://opensource.ym.dev/YMFF/"

# Platform

Expand Down

0 comments on commit a246b13

Please sign in to comment.