Add --reverse option, add recognition of old AustSync detector. #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current adsc converter implicitly assumes that the X axis direction coincides with the fast direction on the detector. The
--reverse
option has been added to handle the case that these axes point in opposite directions. A reversal in X direction is equivalent to a rotation of 180 degrees around Z, thus X->-X and Y->-Y.In addition, the
ELEMENT_Y
axis for the detector was originally fixed to[0 1 0]
which is "up" for the non-reverse case, even though the "natural" direction forELEMENT_Y
is always down because the origin of detector coordinates is at the top left looking from the sample. As a result, thedisplacement_increment
for this axis was negative. The current pull request changes this so that theELEMENT_Y
direction is always down and thedisplacement_increment
is always positive.Recognition of an old Australian Synchrotron MX-1 detector has also been added.