Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --reverse option, add recognition of old AustSync detector. #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamesrhester
Copy link

The current adsc converter implicitly assumes that the X axis direction coincides with the fast direction on the detector. The --reverse option has been added to handle the case that these axes point in opposite directions. A reversal in X direction is equivalent to a rotation of 180 degrees around Z, thus X->-X and Y->-Y.

In addition, the ELEMENT_Y axis for the detector was originally fixed to [0 1 0] which is "up" for the non-reverse case, even though the "natural" direction for ELEMENT_Y is always down because the origin of detector coordinates is at the top left looking from the sample. As a result, the displacement_increment for this axis was negative. The current pull request changes this so that the ELEMENT_Y direction is always down and the displacement_increment is always positive.

Recognition of an old Australian Synchrotron MX-1 detector has also been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant