Added missing settings to query_service_config in local_ydb (#2021)

ydb-platform · Feb 16, 2024 · 3afcaf9 · 3afcaf9
1 parent 126ee0c
commit 3afcaf9
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/ydb/public/tools/lib/cmds/__init__.py b/ydb/public/tools/lib/cmds/__init__.py
@@ -271,7 +271,7 @@ def generic_connector_config():
 
     valid_schemes = ['grpc', 'grpcs']
     if parsed.scheme not in valid_schemes:
-        raise ValueError("Invalid schema '{}' in FQ_CONNECTOR_ENDPOINT (possible: {})".format(parsed.schema, valid_schemes))
+        raise ValueError("Invalid schema '{}' in FQ_CONNECTOR_ENDPOINT (possible: {})".format(parsed.scheme, valid_schemes))
 
     cfg = TGenericConnectorConfig()
     cfg.Endpoint.host = parsed.hostname

diff --git a/ydb/tests/library/harness/kikimr_config.py b/ydb/tests/library/harness/kikimr_config.py
@@ -397,7 +397,17 @@ def __init__(
                         "port": generic_connector_config.Endpoint.port,
                     },
                     "use_ssl": generic_connector_config.UseSsl
-                }
+                },
+                "default_settings": [
+                    {
+                        "name": "DateTimeFormat",
+                        "value": "string"
+                    },
+                    {
+                        "name": "UsePredicatePushdown",
+                        "value": "true"
+                    }
+                ]
             }
 
             self.yaml_config["feature_flags"]["enable_external_data_sources"] = True

diff --git a/ydb/tests/library/ut/kikimr_config.py b/ydb/tests/library/ut/kikimr_config.py
@@ -15,5 +15,9 @@ def test_kikimr_config_generator_generic_connector_config():
     assert yaml_config["query_service_config"]["generic"]["connector"]["endpoint"]["host"] == generic_connector_config.Endpoint.host
     assert yaml_config["query_service_config"]["generic"]["connector"]["endpoint"]["port"] == generic_connector_config.Endpoint.port
     assert yaml_config["query_service_config"]["generic"]["connector"]["use_ssl"] == generic_connector_config.UseSsl
+    assert yaml_config["query_service_config"]["generic"]["default_settings"] == [
+        {"name": "DateTimeFormat", "value": "string"},
+        {"name": "UsePredicatePushdown", "value": "true"},
+    ]
     assert yaml_config["feature_flags"]["enable_external_data_sources"] is True
     assert yaml_config["feature_flags"]["enable_script_execution_operations"] is True