Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemeshard: split schemeshard__operation_common.cpp, move code from .h #10631

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Oct 18, 2024

Move operation specific content of schemeshard__operation_common.cpp (bsv, cdc_stream, pq, subdomain) into separate files.
Move dependency rich methods definitions out of schemeshard__operation_common.h.

This is part of "improve schemeshard operation build-time" effort (#10633).

Changelog category

  • Not for changelog

Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 17:51:24 UTC Pre-commit check linux-x86_64-release-asan for 8be8a53 has started.
2024-10-18 17:51:36 UTC Artifacts will be uploaded here
2024-10-18 17:54:45 UTC ya make is running...
🟡 2024-10-18 20:04:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10503 10003 0 156 218 126

🟢 2024-10-18 20:05:00 UTC Build successful.
🟢 2024-10-18 20:05:39 UTC ydbd size 5.7 GiB changed* by -6.7 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ae2d032 merge: 8be8a53 diff diff %
ydbd size 6 104 555 208 Bytes 6 097 577 648 Bytes -6.7 MiB -0.114%
ydbd stripped size 1 521 873 104 Bytes 1 522 092 592 Bytes +214.3 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 17:51:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8be8a53 has started.
2024-10-18 17:51:38 UTC Artifacts will be uploaded here
2024-10-18 17:54:42 UTC ya make is running...
🟡 2024-10-18 19:01:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15411 13919 0 4 1389 99

2024-10-18 19:02:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-18 19:14:04 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 10 0 0 0 92

🟢 2024-10-18 19:14:11 UTC Build successful.
🟢 2024-10-18 19:14:30 UTC ydbd size 2.8 GiB changed* by -2.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ae2d032 merge: 8be8a53 diff diff %
ydbd size 3 013 081 048 Bytes 3 010 889 880 Bytes -2.1 MiB -0.073%
ydbd stripped size 477 722 584 Bytes 477 935 704 Bytes +208.1 KiB +0.045%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon merged commit ff01ea7 into ydb-platform:main Oct 21, 2024
12 checks passed
@ijon ijon deleted the schemeshard-split-operation-common branch October 21, 2024 15:14
san-kir-k pushed a commit to spaikus/ydb that referenced this pull request Oct 21, 2024
….h (ydb-platform#10631)

Move operations specific content of schemeshard__operation_common.cpp (bsv, cdc_stream, pq, subdomain) into separate files.
Move dependency rich methods definitions out of schemeshard__operation_common.h.

This is part of "improve schemeshard operations build time" effort (ydb-platform#10633).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants