-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change some event scopes from struct
to namespace
#10685
base: main
Are you sure you want to change the base?
Conversation
4b688f3
to
77bdc68
Compare
77bdc68
to
5971b51
Compare
5971b51
to
56dbe49
Compare
56dbe49
to
2daaa51
Compare
That requre changing event definition scopes from `struct` to `namespace`.
2daaa51
to
8a03473
Compare
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
For those components, which events are used by schemeshard and scheme operations.
When event classes are declared as inner classes of a
struct
, it is impossible to make forward declarations of those classes (without refactoring all those definitions in a specific way). Changing event scope fromstruct
tonamespace
enables easy forwarding of event classes of that scope.This is part of "improve schemeshard operation build-time" effort (#10633).
Changelog category