Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in YQL node creation for indexImplTable table settings #10741

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Oct 22, 2024

Ticket:

Forgot to quote the tableSettings node that is created while parsing CREATE TABLE with an index definition or ALTER TABLE ADD INDEX with indexImplTable settings. It is not possible to issue this commands via YQL, because the relevant grammar is not implemented yet, so it is not possible for users to catch this bug.

For those, who are curios if the test does in fact catch the bug, here is the log of the test after I have reverted the fix:

test failure
(CompileExpr(*alterTableAst, alterTableExpr, exprContext, nullptr, nullptr)) <main>: Error: First item in list is not an atom, did you forget quote?

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

github-actions bot commented Oct 23, 2024

2024-10-23 11:16:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 34aff34 has started.
2024-10-23 11:16:56 UTC Artifacts will be uploaded here
2024-10-23 11:20:26 UTC ya make is running...

Copy link

github-actions bot commented Oct 23, 2024

2024-10-23 11:17:08 UTC Pre-commit check linux-x86_64-release-asan for 34aff34 has started.
2024-10-23 11:17:19 UTC Artifacts will be uploaded here
2024-10-23 11:20:23 UTC ya make is running...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant