Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gulpfile.js #788

Closed
wants to merge 1 commit into from

Conversation

yuvashrikarunakaran
Copy link

Missing Dependencies: Ensure that the following modules are installed:

gulp
gulp-load-plugins
gulp-sass
gulp-babel
gulp-eslint
gulp-imagemin
gulp-postcss
gulp-uglify
gulp-htmlmin
gulp-useref
gulp-size
del
cssnano
autoprefixer
yargs
browser-sync
mkdirp
modernizr (if needed)
gulp-if

Missing Dependencies: Ensure that the following modules are installed:

gulp
gulp-load-plugins
gulp-sass
gulp-babel
gulp-eslint
gulp-imagemin
gulp-postcss
gulp-uglify
gulp-htmlmin
gulp-useref
gulp-size
del
cssnano
autoprefixer
yargs
browser-sync
mkdirp
modernizr (if needed)
gulp-if
Copy link
Member

@silvenon silvenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit I don't understand much of this PR, why are there checks for .html files whether they are .js or .css, why are checks for incudeSass removed, where is this all going?

And how come you're suddenly taking interesting in this very old generator? Why not use a build tool like Vite? I know it's not very maintainery of me to recommend a different tool, but I don't understand the appeal of a complex gulp setup in this day and age.

@UlisesGascon
Copy link
Member

And how come you're suddenly taking interesting in this very old generator?

@silvenon seems like AI/bot activity to me 🤔

@silvenon
Copy link
Member

silvenon commented Dec 20, 2024

seems like AI/bot activity to me 🤔

Agreed. Since there was no response I'll close it, and reopen it if there's any meaningful explanation provided, and perspective to steer this in a way to improve the generator.

@silvenon silvenon closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants