Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPack support #1950

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add CPack support #1950

merged 1 commit into from
Sep 25, 2024

Conversation

zjyhjqs
Copy link
Contributor

@zjyhjqs zjyhjqs commented Sep 22, 2024

No description provided.

@sum01
Copy link
Contributor

sum01 commented Sep 22, 2024

I've only briefly messed with Cpack before, but aren't there quite a few vars that should be set? A lot of things don't seem to have defaults (or not defaults you'd want at least).

I recall that it also required quite a few generator-specific vars (like the dependency variables) be set for some generators (like deb files).

@zjyhjqs
Copy link
Contributor Author

zjyhjqs commented Sep 23, 2024

but aren't there quite a few vars that should be set? A lot of things don't seem to have defaults (or not defaults you'd want at least).

The main variables required by CPack are defaulted from project(), so for a modern CMake project it's generally fine.

You could take a try with my presets:
cmake --workflow --preset "unknown-unknown-clang"
CMakeUserPresets.json


I recall that it also required quite a few generator-specific vars (like the dependency variables) be set for some generators (like deb files).

For the more commonly used packaging tools, .e.g. zip, tgz, that's not necessary. (Indeed, the mandatary variables for DEB generator have defaults)

@yhirose yhirose merged commit 996acc5 into yhirose:master Sep 25, 2024
4 checks passed
@yhirose
Copy link
Owner

yhirose commented Sep 25, 2024

Thanks for your contribution!

@zjyhjqs zjyhjqs deleted the feat/cpack-support branch September 26, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants