Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix autodep regression by #2321 (closes #2344) #2377

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix autodep regression by #2321 (closes #2344) #2377

wants to merge 3 commits into from

Conversation

atusy
Copy link
Collaborator

@atusy atusy commented Oct 19, 2024 •
edited
Loading

recreating #2374.
In #2374, I pushed my branch to original repo, not my fork.

atusy
atusy commented Oct 19, 2024
View reviewed changes
tests/testit/test-cache.R
dep_list$restore()
knit_code$restore()

assert('dep_auto() solves dependencies of parent and child documents', {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihui @cderv
Should this test case pass?

As far as I tried, the test fails even if calling dep_auto(labels = all_labels() on every chunk.
This implies knitr has hailed to solve this kind of complex cache dependencies even before #2344.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autodep regression by #2321
1 participant
@atusy