Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update references for commits, tags, etc #329

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Oct 1, 2024

Automated changes by create-pull-request GitHub action

@deribaucourt
Copy link
Member

@WilsonZiweiWang The vscode version should be aligned with the one contained in the client/package.json and server/package.json. Can we edit how the dependency bumps are generated to align all package.json files?

@WilsonZiweiWang
Copy link
Contributor

@WilsonZiweiWang The vscode version should be aligned with the one contained in the client/package.json and server/package.json. Can we edit how the dependency bumps are generated to align all package.json files?

I think you meant to say the root package.json and client package.json because the server's package.json doesn't need vscode. In my research, the engine field indicates the minimum vscode version the extension is compatible with. If a user wants to run our extension, he must make sure his vscode is at least 1.92.0 or he will see an update button on our extension page telling him to update the vscode first. In our tests, we are testing our extension against the latest vscode, and it should be backward compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants