chore: delete TODOs

yoctoyotta1024 · Apr 9, 2024 · 14ee189 · 14ee189
1 parent 96a6734
commit 14ee189
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 14 deletions.
diff --git a/docs/source/usage/requirements.rst b/docs/source/usage/requirements.rst
@@ -1,7 +1,7 @@
 Requirements
 ============
 
-TODO(CB) update requirements with micromambda package installer advice
+TODO(CB) update requirements with formating of code?
 
 The following requirements ensure CLEO's build, compilation and
 execution on DKRZ's Levante HPC. If they do not work,

diff --git a/libs/observers/collect_data_for_dataset.hpp b/libs/observers/collect_data_for_dataset.hpp
@@ -20,8 +20,6 @@
  * structs to collect data within parallel loops and write it to arrays in a dataset
  */
 
-// TODO(CB) document observers
-
 #ifndef LIBS_OBSERVERS_COLLECT_DATA_FOR_DATASET_HPP_
 #define LIBS_OBSERVERS_COLLECT_DATA_FOR_DATASET_HPP_
 
@@ -40,16 +38,16 @@
  * @tparam CDD The type that satisfies the CollectDataForDataset concept.
  */
 template <typename CDD, typename Store>
-concept CollectDataForDataset =
-    requires(CDD cdd, const Dataset<Store> &ds, const viewd_constgbx d_gbxs,
-             const viewd_constsupers totsupers, const size_t sz) {
-      { cdd.get_functor(d_gbxs, totsupers) };
-      { cdd.reallocate_views(sz) } -> std::same_as<void>;
-      { cdd.write_to_arrays(ds) } -> std::same_as<void>;
-      { cdd.write_to_ragged_arrays(ds) } -> std::same_as<void>;
-      { cdd.write_arrayshapes(ds) } -> std::same_as<void>;
-      { cdd.write_ragged_arrayshapes(ds) } -> std::same_as<void>;
-    };
+concept CollectDataForDataset = requires(CDD cdd, const Dataset<Store> &ds,
+                                         const viewd_constgbx d_gbxs,
+                                         const viewd_constsupers totsupers, const size_t sz) {
+  {cdd.get_functor(d_gbxs, totsupers)};
+  { cdd.reallocate_views(sz) } -> std::same_as<void>;
+  { cdd.write_to_arrays(ds) } -> std::same_as<void>;
+  { cdd.write_to_ragged_arrays(ds) } -> std::same_as<void>;
+  { cdd.write_arrayshapes(ds) } -> std::same_as<void>;
+  { cdd.write_ragged_arrayshapes(ds) } -> std::same_as<void>;
+};
 
 /**
  * @brief struct is a new CollectDataForDataset formed from the combination of two structs that

diff --git a/libs/runcleo/runcleo.hpp b/libs/runcleo/runcleo.hpp
@@ -192,7 +192,6 @@ class RunCLEO {
    * library's `std::min` to find `t_next` (also GPU compatible).
    *
    * @see SDMMethods::get_couplstep()
-   * @see SDMMethods::ObsClass::next_obs() // TODO(CB) fill in and reference "ObsClass" docs
    */
   unsigned int get_next_step(const unsigned int t_mdl) const {
     const auto next_couplstep = [&, t_mdl]() {