Trim search query strings to prevent newlines expanding search page (#…

…1600) Trim search query strings
yomidevs · Nov 25, 2024 · 49be0db · 49be0db
1 parent 095160e
commit 49be0db
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/ext/js/display/query-parser.js b/ext/js/display/query-parser.js
@@ -304,13 +304,14 @@ export class QueryParser extends EventDispatcher {
             termNode.className = 'query-parser-term';
             termNode.dataset.offset = `${offset}`;
             for (const {text, reading} of term) {
+                const trimmedText = text.trim();
                 if (reading.length === 0) {
-                    termNode.appendChild(document.createTextNode(text));
+                    termNode.appendChild(document.createTextNode(trimmedText));
                 } else {
-                    const reading2 = this._convertReading(text, reading);
-                    termNode.appendChild(this._createSegment(text, reading2, offset));
+                    const reading2 = this._convertReading(trimmedText, reading);
+                    termNode.appendChild(this._createSegment(trimmedText, reading2, offset));
                 }
-                offset += text.length;
+                offset += trimmedText.length;
             }
             fragment.appendChild(termNode);
         }

diff --git a/ext/js/display/search-display-controller.js b/ext/js/display/search-display-controller.js
@@ -237,7 +237,7 @@ export class SearchDisplayController {
         this._searchBackButton.hidden = !showBackButton;
 
         if (this._queryInput.value !== query) {
-            this._queryInput.value = query;
+            this._queryInput.value = query.trim();
             this._updateSearchHeight(true);
         }
         this._setIntroVisible(!valid, animate);