fix insertion performance issues for our Group
structures
#168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smol-rs/futures-lite#93 (comment) showed a performance issue with
FutureGroup
. The issue turned out to be related to thebitvec
crate performing really poorly ifresize
was called trivially. By instead guarding against calls toresize
this issue goes away entirely.This did not show up in our benchmarks because never exercised
insert
as part of the actual benchmark; we factored it out as part of the test setup. This is theoretically more "correct", but it also didn't surface the issue. We should probably consider adding end-to-end benchmarks for all of our operations too to catch any potential issues elsewhere. Especially for ourGroup
structures. Thanks!Benchmark results
Using the benchmarks authored by @notgull in this repo, running for 10.000 times (rather than 1 million):
before
after