Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #22
Makes
{array,vec}::race
fair. Apparently we did not yet implement fair scheduling for therace
combinators; this fixes it.Additionally it seems we don't have a need for
PollState
in these structs because on the first "success" poll we immediately terminate. So we don't need to track state over time.There is some perf regression, but that's expected because we do more work. But also: I'm not sure how good our
race
benches actually are since they don't actually measure repeated polling - they will always return on the first call topoll
. For it to really show we'd have to author benches which return on thenth
poll - but that's significantly harder and probably not worth it.