[Addition/Multiplication of BigIntegers] add testcase / change constraint of T #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ありがとうございます。 |
|
2da64af#diff-45830cbe94b2fccd3855b98b24114a0519eddb50af033c6d75dc9df41af66312R23-R24 large_small でテストケースが 2 個できていないので意図通りではなさそうです。 （レビューを投稿したつもりになっていて失敗していたので遅れてしまいました。） |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discord の議論にしたがって、下記を行った。
・ (large,small) , (small,large) の 2 ケースからなる入力を追加
・T の制約を変更（テストケースそのものはほとんど変わってない、制約変更はしたくない運用だと思うけど直後なのでゆるしてー）
・制約を残す場合、worst case が 1桁1桁 を T 個並べたものになりえて、それを入れるより良いかなということです。