Skip to content

Commit

Permalink
[YDS-#195] improve : gradle 버전 / JDK version update
Browse files Browse the repository at this point in the history
  • Loading branch information
coding-polarbear committed Jan 15, 2024
1 parent 23fde8d commit 7846019
Show file tree
Hide file tree
Showing 12 changed files with 26 additions and 26 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/buildTest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
- uses: actions/checkout@v3

# gradle 빌드을 위해 JDK를 세팅합니다.
- name: set up JDK 11
- name: set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '11'
java-version: '17'
distribution: 'temurin'
cache: gradle

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deployDevStoryBook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
properties: 'versionName'

# gradle 빌드을 위해 JDK를 세팅합니다.
- name: set up JDK 11
- name: set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '11'
java-version: '17'
distribution: 'temurin'
cache: gradle

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deployLibraryYDS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
properties: 'versionName'

# gradle 빌드을 위해 JDK를 세팅합니다.
- name: set up JDK 11
- name: set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '11'
java-version: '17'
distribution: 'temurin'
cache: gradle

Expand Down
9 changes: 4 additions & 5 deletions DesignSystem/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ android {
defaultConfig {
minSdkVersion 23
targetSdkVersion 33
versionCode((System.getenv("BUILD_NUMBER") as Integer ?: 10000))
versionName versionProperties['versionName']
vectorDrawables.useSupportLibrary = true

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
Expand All @@ -29,18 +27,19 @@ android {
}
}
compileOptions {
sourceCompatibility JavaVersion.VERSION_11
targetCompatibility JavaVersion.VERSION_11
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = '11'
jvmTarget = '17'
freeCompilerArgs += [
"-Xjvm-default=all",
]
}
buildFeatures {
dataBinding = true
}
namespace 'com.yourssu.design'
}

afterEvaluate {
Expand Down
3 changes: 1 addition & 2 deletions DesignSystem/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.yourssu.design">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<uses-permission android:name = "android.permission.VIBRATE" />
</manifest>
7 changes: 4 additions & 3 deletions app/storybook/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ android {
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
targetCompatibility JavaVersion.VERSION_11
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = '11'
jvmTarget = '17'
}
composeOptions {
kotlinCompilerExtensionVersion = "1.4.3"
Expand All @@ -70,6 +70,7 @@ android {
dataBinding = true
compose = true
}
namespace 'com.yourssu.storybook'
}

dependencies {
Expand Down
3 changes: 1 addition & 2 deletions app/storybook/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.yourssu.storybook">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application
android:allowBackup="false"
Expand Down
7 changes: 4 additions & 3 deletions app/yds-ui-tester/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,17 @@ android {
}
}
compileOptions {
sourceCompatibility JavaVersion.VERSION_11
targetCompatibility JavaVersion.VERSION_11
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = '11'
jvmTarget = '17'
}

buildFeatures {
dataBinding = true
}
namespace 'com.yourssu.yds_ui_tester'
}

dependencies {
Expand Down
3 changes: 1 addition & 2 deletions app/yds-ui-tester/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.yourssu.yds_ui_tester">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application
android:allowBackup="false"
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ buildscript {
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:7.3.1'
classpath 'com.android.tools.build:gradle:8.2.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath "com.github.dcendents:android-maven-gradle-plugin:2.1"

Expand Down
4 changes: 3 additions & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,6 @@ android.enableJetifier=false
# Kotlin code style for this project: "official" or "obsolete":
kotlin.code.style=official

android.disableAutomaticComponentCreation=true
android.defaults.buildfeatures.buildconfig=true
android.nonTransitiveRClass=false
android.nonFinalResIds=false
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Sun Jul 10 02:28:18 KST 2022
distributionBase=GRADLE_USER_HOME
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2-bin.zip
distributionPath=wrapper/dists
zipStorePath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME

0 comments on commit 7846019

Please sign in to comment.