Skip to content

Commit

Permalink
Fix
Browse files Browse the repository at this point in the history
  • Loading branch information
madhurajayaraman committed Oct 14, 2024
1 parent 0d0f7ce commit 081ddc5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
6 changes: 2 additions & 4 deletions cobalt/black_box_tests/black_box_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,8 @@ def LoadTests(launcher_params, test_set):
if launcher.SupportsSuspendResume():
test_targets += _TESTS_NEEDING_SYSTEM_SIGNAL

# disabled due to deep linking break after posixification of sockets
# and we don't support deep links
# if launcher.SupportsDeepLink():
# test_targets += _TESTS_NEEDING_DEEP_LINK
if launcher.SupportsDeepLink():
test_targets += _TESTS_NEEDING_DEEP_LINK

if test_set in ['all', 'wpt']:
test_targets += _WPT_TESTS
Expand Down
6 changes: 3 additions & 3 deletions starboard/shared/starboard/link_receiver.cc
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ int CreateServerSocket(SbSocketAddressType address_type) {
}
if (socket_fd < 0) {
SB_LOG(ERROR) << __FUNCTION__ << ": "
<< "Socket create failed";
<< "Socket create failed, errno: " << errno;
return -1;
}

Expand All @@ -70,7 +70,7 @@ int CreateServerSocket(SbSocketAddressType address_type) {
<< "SbSocketSetReuseAddress failed";
return -1;
}

SB_DLOG(INFO) << "Successfully created server socket with fd : " << socket_fd;
return socket_fd;
}

Expand All @@ -81,8 +81,8 @@ int CreateLocallyBoundSocket(SbSocketAddressType address_type, int port) {
return -1;
}

socklen_t socklen;
struct sockaddr_in addr_in = {0};
socklen_t socklen = static_cast<socklen_t>(sizeof(addr_in));
int local_add_result =
getsockname(socket, reinterpret_cast<sockaddr*>(&addr_in), &socklen);

Expand Down

0 comments on commit 081ddc5

Please sign in to comment.