Address feedback

youtube · Nov 19, 2024 · bb4619b · bb4619b
1 parent 02f49d2
commit bb4619b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/.gn b/.gn
@@ -167,11 +167,10 @@ exec_script_whitelist =
       "//tools/gritsettings/BUILD.gn",
     ]
 
-# TODO(b/378960295): Convert python scripts to GN actions.
+# TODO(b/378960295): Try to remove the allowlisted files.
 import("//cobalt/build/configs/cobalt.gni")
-  exec_script_whitelist += [
-    "//starboard/tools/BUILD.gn",
-    "//starboard/build/config/sabi/BUILD.gn",
-    "//starboard/build/platform_path.gni",
-  ]
-
+exec_script_whitelist += [
+  "//starboard/tools/BUILD.gn",
+  "//starboard/build/config/sabi/BUILD.gn",
+  "//starboard/build/platform_path.gni",
+]
diff --git a/cobalt/build/configs/cobalt.gni b/cobalt/build/configs/cobalt.gni
@@ -12,9 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# Get the path to the starboard implementation and include its GN
-# configuration.
-
+# is_cobalt is just declared here and potentially overridden while running gn gen.
 declare_args() {
   is_cobalt = false
 }