Disable lifecycle tracing for performance

youtube · Nov 14, 2024 · fd13e36 · fd13e36
1 parent 999b341
commit fd13e36
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/base/task/sequence_manager/task_queue_impl.cc b/base/task/sequence_manager/task_queue_impl.cc
@@ -1402,6 +1402,7 @@ void TaskQueueImpl::ActivateDelayedFenceIfNeeded(const Task& task) {
   main_thread_only().delayed_fence = absl::nullopt;
 }
 
+#if !defined(STARBOARD)
 void TaskQueueImpl::MaybeReportIpcTaskQueuedFromMainThread(
     const Task& pending_task) {
   if (!pending_task.ipc_hash)
@@ -1502,6 +1503,7 @@ void TaskQueueImpl::ReportIpcTaskQueued(
                 &ctx, pending_task.posted_from));
       });
 }
+#endif
 
 void TaskQueueImpl::OnQueueUnblocked() {
   DCHECK(IsQueueEnabled());

diff --git a/base/task/sequence_manager/task_queue_impl.h b/base/task/sequence_manager/task_queue_impl.h
@@ -536,6 +536,22 @@ class BASE_EXPORT TaskQueueImpl {
 
   // Reports the task if it was due to IPC and was posted to a disabled queue.
   // This should be called after WillQueueTask has been called for the task.
+#if defined(STARBOARD)
+  // We disable the "lifecycles" tracing group in Cobalt for performance
+  // reasons.
+  void MaybeReportIpcTaskQueuedFromMainThread(const Task& pending_task) {};
+  bool ShouldReportIpcTaskQueuedFromAnyThreadLocked(
+      base::TimeDelta* time_since_disabled)
+      EXCLUSIVE_LOCKS_REQUIRED(any_thread_lock_) {
+    return false;
+  }
+  void MaybeReportIpcTaskQueuedFromAnyThreadLocked(const Task& pending_task)
+      EXCLUSIVE_LOCKS_REQUIRED(any_thread_lock_) {}
+  void MaybeReportIpcTaskQueuedFromAnyThreadUnlocked(const Task& pending_task) {
+  }
+  void ReportIpcTaskQueued(const Task& pending_task,
+                           const base::TimeDelta& time_since_disabled) {}
+#else   // !defined(STARBOARD)
   void MaybeReportIpcTaskQueuedFromMainThread(const Task& pending_task);
   bool ShouldReportIpcTaskQueuedFromAnyThreadLocked(
       base::TimeDelta* time_since_disabled)
@@ -545,6 +561,7 @@ class BASE_EXPORT TaskQueueImpl {
   void MaybeReportIpcTaskQueuedFromAnyThreadUnlocked(const Task& pending_task);
   void ReportIpcTaskQueued(const Task& pending_task,
                            const base::TimeDelta& time_since_disabled);
+#endif  // !defined(STARBOARD)
 
   // Invoked when the queue becomes enabled and not blocked by a fence.
   void OnQueueUnblocked();