Exclude unsupported getaddrinfo flags #3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3930 +/- ##
==========================================
- Coverage 57.75% 57.74% -0.02%
==========================================
Files 1779 1768 -11
Lines 86573 86442 -131
==========================================
- Hits 50001 49915 -86
+ Misses 36572 36527 -45 ☔ View full report in Codecov by Sentry. |
b/357161000 Change-Id: I62c935e6792f10bdc80ba9ecfcebae69a011a60f
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
The failing test was actually not intended for Android because Android is not a modular build and `getaddrinfo` does not go through abi wrapper translation. And the test failed because Android uses bionic libc and is not fully posix-compliant. I took a look at the flag usage across all of Cobalt's dependencies and did not see usage of most flags except for `AI_ADDRCONFIG` which does still work on Android. So we exclude the unused flags from test for non-modular build here. b/357161000 Change-Id: I62c935e6792f10bdc80ba9ecfcebae69a011a60f (cherry picked from commit 62cdd00)
johnxwork
added a commit
that referenced
this pull request
Aug 16, 2024
Refer to the original PR: #3930 The failing test was actually not intended for Android because Android is not a modular build and `getaddrinfo` does not go through abi wrapper translation. And the test failed because Android uses bionic libc and is not fully posix-compliant. I took a look at the flag usage across all of Cobalt's dependencies and did not see usage of most flags except for `AI_ADDRCONFIG` which does still work on Android. So we exclude the unused flags from test for non-modular build here. b/357161000 Change-Id: I62c935e6792f10bdc80ba9ecfcebae69a011a60f Co-authored-by: johnx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failing test was actually not intended for Android because Android is not a modular build and
getaddrinfodoes not go through abi wrapper translation. And the test failed because Android uses bionic libc and is not fully posix-compliant. I took a look at the flag usage across all of Cobalt's dependencies and did not see usage of most flags except forAI_ADDRCONFIGwhich does still work on Android. So we exclude the unused flags from test for non-modular build here.b/357161000
Change-Id: I62c935e6792f10bdc80ba9ecfcebae69a011a60f