Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tcp_socket_posix to replace tcp_socket_starboard #3991

Closed
wants to merge 1 commit into from

Conversation

maxz-lab
Copy link
Contributor

b/302741384

Compile verified for linux/evergeen/win32/xb1

b/302741384
@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Aug 15, 2024

Datadog Report

Branch report: maxz-sb16-sb-and-posix
Commit report: beebae5
Test service: cobalt

✅ 0 Failed, 34435 Passed, 6 Skipped, 9m 56.62s Total Time
❄️ 2 New Flaky

New Flaky Tests (2)

  • RainyDayAddToSameWaiter - SbPosixSocketWaiterAddTest - Last Failure

    Expand for error
     ../../starboard/nplb/posix_compliance/posix_socket_waiter_add_test.cc:122
     Value of: SbPosixSocketWaiterAdd( waiter, socket, __null, &NoOpSocketWaiterCallback, kSbSocketWaiterInterestRead | kSbSocketWaiterInterestWrite, false)
       Actual: true
     Expected: false
    
  • SunnyDay - SbPosixSocketWaiterWaitTest - Last Failure

    Expand for error
     ../../starboard/nplb/posix_compliance/posix_socket_waiter_wait_test.cc:93
     Value of: SbPosixSocketWaiterAdd(waiter, *trio.client_socket_fd_ptr, &values, &FailSocketWaiterCallback, kSbSocketWaiterInterestRead, false)
       Actual: true
     Expected: false
    

@maxz-lab maxz-lab closed this Sep 12, 2024
@maxz-lab maxz-lab deleted the maxz-sb16-sb-and-posix branch September 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant