[media] Set the bounds of Sbplayer via video_painter.cc #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
force-pushed
the
android_sbplayer_bound
branch
3 times, most recently
from
f3c2698
to
36d51af
Compare
borongc
requested review from
sideb0ard,
jasonzhangxx,
xiaomings and
osagie98
and removed request for
briantting
borongc
force-pushed
the
android_sbplayer_bound
branch
8 times, most recently
from
fba14f7
to
7402087
Compare
osagie98
reviewed
Nov 12, 2024
jasonzhangxx
approved these changes
Nov 14, 2024
borongc
force-pushed
the
android_sbplayer_bound
branch
2 times, most recently
from
001b361
to
bb12930
Compare
johnxwork
approved these changes
Nov 15, 2024
borongc
force-pushed
the
android_sbplayer_bound
branch
from
bb12930
to
7111333
Compare
kaidokert
approved these changes
Nov 15, 2024
SbPlayer needs SbPlayerSetBounds to update the bounds. This PR updates the bounds in blink via video_painter.cc for SbPlayer. Unlike Cobalt, Chromium upupdates the bounds of video frequently, resulting in multiple calls per video session for SbPlayer. We should revisit it if SbPlayerSetBounds causes performance issues. b/376320224
borongc
force-pushed
the
android_sbplayer_bound
branch
from
7111333
to
b00e647
Compare
osagie98
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SbPlayer needs
SbPlayerSetBoundsto update the bounds. This PR updates the bounds in blink via video_painter.cc for SbPlayer.Unlike Cobalt, Chromium updates the bounds of video frequently, resulting in multiple calls of
SbPlayerSetBoundsper video session for SbPlayer. We should revisit it if the multiple calls ofSbPlayerSetBoundscause performance issues.b/376320224