[media] Add runtime flag to disable StarboardRenderer #4407
+187
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
force-pushed
the
android_renderer
branch
from
6b345ef
to
201c312
Compare
borongc
changed the title
borongc
changed the title
borongc
force-pushed
the
android_renderer
branch
3 times, most recently
from
bdb50e6
to
1f4d7be
Compare
borongc
requested review from
yell0wd0g,
jasonzhangxx and
xiaomings
and removed request for
dahlstrom-g
yell0wd0g
requested changes
Nov 11, 2024
There was a problem hiding this comment.
A few nits. Is there a strong reason to have this as a
runtime switch and not just as a build flag (i.e. build
and use StarboardRenderer, or not)? I'm saying this
because if we give this option, we should test it, which
in turn means more configuration runs. If there's no
strong reason I'd vote for built-time only, which is
easier to debug by non-cobalt developers.
borongc
force-pushed
the
android_renderer
branch
from
1f4d7be
to
e7017c6
Compare
1. Add StarboardRendererFactory for MediaFactory to select StarboardRenderer when `use_starboard_media=true`. 2. Remove hard code StarboardRenderer in WebMediaPlayerImpl. Note RendererType::kStarboard cannot be gated due to mojom files. b/375278384
borongc
force-pushed
the
android_renderer
branch
from
e7017c6
to
03ed894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
use_starboard_media=true, Cobalt.apk uses StarboardRenderer by default. This PR allows Cobalt.apk to select either StarboardRenderer or default Chromium renderer at runtime.Chromium on android uses Surface Control to manage SurfaceView for overlay video mode, which is different from StarboardRenderer. This enables Cobalt team to profile the performance of different renderers, and develop/debug StarboardRenderer. This will be revisited to support secondary videos.
adb shell am start --esa commandLineArgs "--disable-starboard-renderer".use_starboard_media=true.b/375278384