Skip to content

Commit

Permalink
Cherry pick PR #4141: [Docker] Fix base container alias (#4150)
Browse files Browse the repository at this point in the history
Refer to the original PR: youtube/cobalt#4141

Switches the container base image url to a supported alias.

b/369130578

---------

Co-authored-by: Kaido Kert <[email protected]>
  • Loading branch information
cobalt-github-releaser-bot and kaidokert authored Sep 24, 2024
1 parent 525ed7c commit 57d0683
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 12 deletions.
7 changes: 5 additions & 2 deletions .github/actions/docker/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,11 @@ runs:
run: echo "DOCKER_TAG=ghcr.io/${REPO}/${{inputs.docker_image}}:${GITHUB_BASE_REF%.1+}" >> $GITHUB_ENV
shell: bash
- name: Set up Cloud SDK
if: ${{ (steps.changed-files.outputs.any_changed == 'true') && (github.event_name == 'pull_request') && (github.event.pull_request.head.repo.fork) }}
uses: google-github-actions/setup-gcloud@v1
uses: isarkis/setup-gcloud@40dce7857b354839efac498d3632050f568090b6 # v1.1.1
- name: Configure Docker auth for GCloud
shell: bash
run: |
gcloud auth configure-docker
- name: Set Docker Tag
id: set-docker-tag-presubmit-fork
env:
Expand Down
20 changes: 12 additions & 8 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ x-build-volumes: &build-volumes
- ${STARBOARD_TOOLCHAINS_DIR:-container-starboard-toolchains}:/root/starboard-toolchains

x-build-common-definitions: &build-common-definitions
<<: *common-definitions
<<: *build-volumes
<<:
- *common-definitions
- *build-volumes
depends_on:
- build-base

Expand Down Expand Up @@ -150,8 +151,9 @@ services:
CONFIG: ${CONFIG:-debug}

linux-x64x11-xenial:
<<: *common-definitions
<<: *build-volumes
<<:
- *common-definitions
- *build-volumes
build:
context: ./docker/linux
dockerfile: linux-x64x11/Dockerfile
Expand All @@ -163,8 +165,9 @@ services:
scale: 0

linux-x64x11-clang-3-9:
<<: *common-definitions
<<: *build-volumes
<<:
- *common-definitions
- *build-volumes
build:
context: ./docker/linux/
dockerfile: clang-3-9/Dockerfile
Expand All @@ -177,8 +180,9 @@ services:
- linux-x64x11-xenial

linux-x64x11-clang-3-9-prebuilt:
<<: *common-definitions
<<: *build-volumes
<<:
- *common-definitions
- *build-volumes
image: gcr.io/cobalt-tools/build-cobalt-linux-x64x11-clang-3-9:1.4
environment:
<<: *shared-build-env
Expand Down
2 changes: 1 addition & 1 deletion docker/linux/android/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
FROM cobalt-build-base

RUN apt update -qqy \
&& apt install -qqy --no-install-recommends \
&& apt install -qqy \
default-jdk \
g++-multilib \
libxml2-dev \
Expand Down
2 changes: 1 addition & 1 deletion docker/linux/base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

ARG BASE_OS
ARG BASE_OS_TAG
FROM ${BASE_OS:-gcr.io/cloud-marketplace-containers/google/debian10}:${BASE_OS_TAG:-latest}
FROM ${BASE_OS:-marketplace.gcr.io/google/debian10}:${BASE_OS_TAG:-latest}

ENV PYTHONUNBUFFERED 1

Expand Down

0 comments on commit 57d0683

Please sign in to comment.