Retry fixes #82
Open
Retry fixes #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaharuk-yb
commented
May 16, 2023
shaharuk-yb
commented
- added custom transaction status ZERO_ROWS for queries returning zero rows. If any query in a transaction returns zero rows, this transaction will be added. This does not get retried.
hbhanawat
reviewed
May 16, 2023
| @@ -452,7 +456,7 @@ protected final void doWork(DatabaseType databaseType, TransactionType transacti | |||
| conn.rollback(); | |||
|
|
|||
| if (isRetryable(ex)) { | |||
| LOG.debug(String.format("Retryable SQLException occurred during [%s]... current retry attempt [%d], max retry attempts [%d], sql state [%s], error code [%d].", transactionType, retryCount, maxRetryCount, ex.getSQLState(), ex.getErrorCode()), ex); | |||
| LOG.debug(String.format("Retryable SQLException occurred during [%s]... current retry attempt [%d], max retry attempts [%d], sql state [%s], error code [%d].", transactionType, retryCount, maxRetryCount, ex.getSQLState(), ex.getErrorCode())); | |||
There was a problem hiding this comment.
What is the reason to remove ex from the exception log?
| @@ -84,6 +85,10 @@ public Histogram<TransactionType> getRetryDifferent() { | |||
| return retryDifferent; | |||
| } | |||
|
|
|||
| public Histogram<TransactionType> getZeroRows() { | |||
There was a problem hiding this comment.
Can we print number of zero_rows to the command line o/p just like rejected transactions? It will help while running workloads manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.