Unset time from children tablets upon initialization #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suranjan
approved these changes
Jul 25, 2023
Sumukh-Phalgaonkar
pushed a commit
to Sumukh-Phalgaonkar/debezium-connector-yugabytedb
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is possible for a transaction which is committed on a parent tablet that its
APPLYrecords are distributed on both the children tablets after split. Now thisAPPLYrecord can have a lower commit time than the change records we receive from the parent tablets.So after https://phorge.dev.yugabyte.com/D25399 was merged, if we do not reset the time for children tablets, we will end up filtering some records and end up in a data loss situation.
Solution
While adding the children tablets for polling, we are now simply resetting/unsetting the time back to 0 so that when the first
GetChangescall happens, it uses this default value only.