Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running reidentify-DMR on the DMRfind results #85

Open
FarzanehRah opened this issue May 17, 2023 · 6 comments
Open

running reidentify-DMR on the DMRfind results #85

FarzanehRah opened this issue May 17, 2023 · 6 comments

Comments

@FarzanehRah
Copy link

FarzanehRah commented May 17, 2023

Hi,

I'm currently attempting to run reidentify-DMR on the DMRfind results. However, I encountered the following message, setting --sig-cutoff to 1 doesn't change anything:

Begin FDR Correction
Wed May 17 10:47:32 2023

m0 estimate for iteration 0: 0
Histogram FDR correction did not converge. Using the smallest p-value 0.0003333333333333333 as cutoff.

Calculating Residual Cutoff
Wed May 17 10:47:32 2023

There are no null residuals to calculate resid_cutoff. Using 2 as the cutoff.
Begin Defining Windows
Wed May 17 10:47:32 2023

Setting --sig-cutoff to 1 doesn't change anything. Additionally, when I attempt to set the --resid-cutoff parameter, I receive the following error:
methylpy reidentify-DMR: error: argument --resid-cutoff: invalid int value: '0.05'

Any advice or suggestions would be greatly appreciated.
Thanks

@yupenghe
Copy link
Owner

It was due to a bug in the code. It should be fixed in the latest version 1.4.7
Could you try it again after updating the methylpy version?

@FarzanehRah
Copy link
Author

Thank you so much. Regarding the --resid-cutoff, I was able to define the value successfully. However, I'm still encountering an issue even after setting --sig-cutoff to 1:
"m0 estimate for iteration 0: 0. Histogram FDR correction did not converge. Using the smallest p-value 0.0003333333333333333 as cutoff."

@yupenghe
Copy link
Owner

Yes that usually means that the methylation difference the input samples is small and methylpy cannot find many DMSs/DMRs.

@FarzanehRah
Copy link
Author

Thank you for your response.
I'm curious if it would be possible to obtain some results by increasing the FDR threshold. Would that potentially yield some DMSs/DMRs? Additionally, I'm interested in understanding how we can change the smallest p-value (0.0003333333333333333) as the cutoff?

@yupenghe
Copy link
Owner

You can increase the number of simulations by assigning a larger number to --num-sims. Current default is 3000 and the smallest p-value equals to 1 / num_sims.

@FarzanehRah
Copy link
Author

Thank you so much for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants