Skip to content

Commit

Permalink
fix(ci): windows build (#135)
Browse files Browse the repository at this point in the history
Closes #134.

- [x] upgrade pyinstaller to support the latest `setuptools`
- [x] add a CI step to validate the windows build MSI before the release
  • Loading branch information
yurijmikhalevich authored Aug 17, 2024
1 parent 9ba665e commit fd58582
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 5 deletions.
19 changes: 17 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ jobs:
python -m pip install --upgrade pip
pip install --upgrade poetry
poetry install
poetry run pip install pyinstaller==5.13.2
poetry run pip install pyinstaller==6.10.0
- run: make build-windows
- name: Install Advinst
uses: caphyon/advinst-github-action@main
Expand All @@ -182,8 +182,23 @@ jobs:
path: signed/rclip-*.msi
if-no-files-found: error

windows-validate:
needs: [parse_tag, windows]
runs-on: windows-2022
steps:
- uses: actions/download-artifact@v3
with:
name: windows
- name: Install MSI
run: Start-Process msiexec.exe -Wait -ArgumentList '/i rclip-${{ needs.parse_tag.outputs.version }}.msi /quiet'
- name: Ensure it works
run: |
Import-Module "$env:ChocolateyInstall/helpers/chocolateyInstaller.psm1"
refreshenv
rclip cat
create_release:
needs: [parse_tag, pypi, snap, appimage, windows]
needs: [parse_tag, pypi, snap, appimage, windows-validate]
# the windows job doesn't run for pre-releases, but we need to create a release for pre-releases too
if: ${{ !cancelled() }}
runs-on: ubuntu-22.04
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "rclip"
version = "1.10.2"
version = "1.10.3a18"
description = "AI-Powered Command-Line Photo Search Tool"
authors = ["Yurij Mikhalevich <[email protected]>"]
license = "MIT"
Expand Down
4 changes: 2 additions & 2 deletions snap/snapcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ description: |
For a detailed demonstration, watch the video: https://www.youtube.com/watch?v=tAJHXOkHidw.
You can use another image as a query by passing a file path or even an URL to the image file to **rclip** and combine multiple queries. Check out the project's README on GitHub for more usage examples: https://github.com/yurijmikhalevich/rclip#readme.
version: 1.10.2
version: 1.10.3a18
website: https://github.com/yurijmikhalevich/rclip
contact: [email protected]
passthrough:
Expand All @@ -31,7 +31,7 @@ apps:
parts:
rclip:
plugin: python
source: ./snap/local/rclip-1.10.2.tar.gz
source: ./snap/local/rclip-1.10.3a18.tar.gz
build-packages:
- python3-pip
build-environment:
Expand Down

0 comments on commit fd58582

Please sign in to comment.