Fix False Positive Vendor Prefix Error (#27)

yuschick · Dec 28, 2023 · 7af73b7 · 7af73b7
1 parent eb0f6cd
commit 7af73b7
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "stylelint-plugin-defensive-css",
-  "version": "0.10.2",
+  "version": "0.10.3",
   "description": "A Stylelint plugin to enforce defensive CSS best practices.",
   "main": "src/index.js",
   "files": [

diff --git a/src/rules/use-defensive-css/index.test.js b/src/rules/use-defensive-css/index.test.js
@@ -483,6 +483,21 @@ testRule({
   config: [true, { 'vendor-prefix-grouping': true }],
   plugins: ['./index.js'],
   accept: [
+    {
+      code: `.menu-item {
+	&.menu-item-has-children::after,
+	&.menu-item-has-grandchildren::after {
+		content: '';
+		position: absolute;
+		top: 24px;
+		right: 30px;
+		width: 18px;
+		height: 18px;
+		background-size: contain;
+	}
+}`,
+      description: 'Nested scss with no prefixes defined.',
+    },
     {
       code: `input::-webkit-input-placeholder { color: #222; } input::-moz-placeholder { color: #222; }`,
       description:

diff --git a/src/utils/findVendorPrefixes.js b/src/utils/findVendorPrefixes.js
@@ -1,9 +1,11 @@
-const expression = /-[moz|ms|o|webkit|]+-/g;
+const expression = /-\b(moz|ms|o|webkit)\b-/g;
 
 function findVendorPrefixes(selector) {
+  console.log(selector);
   if (!selector) return false;
 
   let prefixesFound = [...selector.trim().matchAll(expression)];
+  console.log(prefixesFound);
   return prefixesFound.length > 1;
 }